Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists - GPU Compile updates #471

Merged
merged 2 commits into from
Nov 7, 2024
Merged

CMakeLists - GPU Compile updates #471

merged 2 commits into from
Nov 7, 2024

Conversation

kiritigowda
Copy link
Collaborator

  • Remove GFX 940/1
  • Use updated GPU_TARGETS

@kiritigowda kiritigowda added enhancement New feature or request ci:precheckin labels Nov 5, 2024
@kiritigowda kiritigowda self-assigned this Nov 5, 2024
@kiritigowda kiritigowda requested a review from rrawther November 6, 2024 19:05
amd-aakash
amd-aakash approved these changes Nov 7, 2024
View reviewed changes
Copy link

@amd-aakash amd-aakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiritigowda kiritigowda merged commit 6ede5bf into ROCm:develop Nov 7, 2024
4 checks passed
@kiritigowda kiritigowda deleted the kg/deps-updates branch November 7, 2024 23:06
kiritigowda added a commit that referenced this pull request Nov 13, 2024
@kiritigowda
CMakeLists - GPU Compile updates (#471)
1339ab3
kiritigowda added a commit that referenced this pull request Nov 13, 2024
@kiritigowda
Revert "CMakeLists - GPU Compile updates (#471)"
6ac6981 
This reverts commit 1339ab3.
Dineshbabu-Ravichandran pushed a commit to Dineshbabu-Ravichandran/rpp that referenced this pull request Nov 14, 2024
@kiritigowda @Dineshbabu-Ravichandran
CMakeLists - GPU Compile updates (ROCm#471)
5cb9ba9
Dineshbabu-Ravichandran pushed a commit to Dineshbabu-Ravichandran/rpp that referenced this pull request Nov 14, 2024
@kiritigowda @Dineshbabu-Ravichandran
CMakeLists - GPU Compile updates (ROCm#471)
1eb2d01
kiritigowda added a commit that referenced this pull request Nov 15, 2024
@kiritigowda
ROCm 6.3 Cherry-pick - GPU Compile updates (#471) (#475)
fe68edd 
* CMakeLists - GPU Compile updates (#471)

* Revert "CMakeLists - GPU Compile updates (#471)"

This reverts commit 1339ab3.

* GFX ID - remove 940/1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amd-aakash amd-aakash amd-aakash approved these changes

@rrawther rrawther Awaiting requested review from rrawther

Assignees

@kiritigowda kiritigowda

Labels
ci:precheckin enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiritigowda @amd-aakash