Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aten operators #46

Merged
merged 14 commits into from
Nov 15, 2023
Merged

Update aten operators #46

merged 14 commits into from
Nov 15, 2023

Conversation

TedThemistokleous
Copy link
Contributor

@TedThemistokleous TedThemistokleous commented Oct 25, 2023

Add converter for athen.hardtanh similar to that of clamp
Add converter for aten.hardswish
Add converter for aten.elu
Add converter for aten.max
Add converter for aten.min (free and similar to max)
Add converter for aten.stack

Add converter for hardtanh similar to that of clamp
@TedThemistokleous TedThemistokleous self-assigned this Oct 25, 2023
@TedThemistokleous TedThemistokleous linked an issue Oct 25, 2023 that may be closed by this pull request
9 tasks
@TedThemistokleous TedThemistokleous marked this pull request as ready for review October 25, 2023 17:39
@TedThemistokleous TedThemistokleous changed the title Update aten.hardtanh support Update aten operators Oct 25, 2023
Had to add my owwn migraphx converter as the order of value return to clip would fail the test
Was breaking when trying to use elu converter for aten elu converter op
- Test for both non parameterize and parametertized for alpha/default values
Handle getting max value from input tensor.
Similar to the onnx reduce_min operator, implimentatin is similar to that of mean, max and map to similar reduce ops in MIGraphX.

This one is a freebie when doing max
Required if we want to support min() operator down the road.

Added converter for fx and dynamo in similar vein as the argmax function.

Also added unit tests
Updated unit tests as well
added changes to unit tests and fix operators to handle multi input args correctly.
@shivadbhavsar
Copy link
Collaborator

Format the all the py files using yapf

- remove print in stack
- merge argmin argmax in testing
- rename test_leak_relu -> test_single_param_activation_funcs
- Add default for min dim=None
@TedThemistokleous TedThemistokleous added enhancement New feature or request TorchMIGraphX For internal tracking labels Nov 15, 2023
@shivadbhavsar shivadbhavsar merged commit ff8ac13 into master Nov 15, 2023
@TedThemistokleous TedThemistokleous deleted the add_aten_ops branch November 15, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TorchMIGraphX For internal tracking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TIMM unsupported ops
2 participants