-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aten operators #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add converter for hardtanh similar to that of clamp
9 tasks
Had to add my owwn migraphx converter as the order of value return to clip would fail the test
TedThemistokleous
force-pushed
the
add_aten_ops
branch
from
October 25, 2023 19:04
4cabff1
to
e9fe731
Compare
Was breaking when trying to use elu converter for aten elu converter op
- Test for both non parameterize and parametertized for alpha/default values
Handle getting max value from input tensor.
TedThemistokleous
force-pushed
the
add_aten_ops
branch
from
October 30, 2023 19:05
ecceef7
to
b154ac2
Compare
Similar to the onnx reduce_min operator, implimentatin is similar to that of mean, max and map to similar reduce ops in MIGraphX. This one is a freebie when doing max
Required if we want to support min() operator down the road. Added converter for fx and dynamo in similar vein as the argmax function. Also added unit tests
Updated unit tests as well
added changes to unit tests and fix operators to handle multi input args correctly.
Format the all the py files using yapf |
- remove print in stack - merge argmin argmax in testing - rename test_leak_relu -> test_single_param_activation_funcs - Add default for min dim=None
TedThemistokleous
added
enhancement
New feature or request
TorchMIGraphX
For internal tracking
labels
Nov 15, 2023
shivadbhavsar
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add converter for athen.hardtanh similar to that of clamp
Add converter for aten.hardswish
Add converter for aten.elu
Add converter for aten.max
Add converter for aten.min (free and similar to max)
Add converter for aten.stack