Fix Tensorflow package check #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
should this also be an upstream fix ? |
Yes. I'll open an PR. |
jayfurmanek
force-pushed
the
IFU-master-2023-10-10-tf-fix
branch
from
6a51029
to
bdafd6e
Compare
|
looks like this is not needed along with the IFU. closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the
_is_package_availablefunction. As it is it will fail for all TF variants since even if they are installed since it will fail to get the metadata under the same name. Further down in this utils file there is code to check which variant (intel, rocm, etc) and get the metadata with the proper name, but it will never get that far because this updated version of _is_package_available` will always be False.