Skip to content

Conversation

@Rohan138
Copy link

@Rohan138 Rohan138 commented Nov 13, 2025

aiter/main: https://github.com/ROCm/aiter/blob/main/aiter/ops/shuffle.py
aiter/355_wip: https://github.com/ROCm/aiter/blob/355_wip/aiter/ops/shuffle.py

Fixes shuffle_mxfp4_scale vs shuffle_scale_a16w4 differences, but the expected src input tensor shapes for shuffle_weight_a16w4 (e, n, k) and shuffle_scale_a16w4 (e * n, k) are internally inconsistent in aiter/main (ROCm/aiter#1341). We should probably go fix this in aiter main.

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@Rohan138 Rohan138 marked this pull request as ready for review November 13, 2025 22:02
@Rohan138
Copy link
Author

cc @dllehr-amd @coderfeli PTAL

@Rohan138 Rohan138 requested a review from gshtras as a code owner November 14, 2025 22:10
@Rohan138 Rohan138 force-pushed the ropotdar/fix_a16w4_main branch from 8c0cd79 to 9773275 Compare November 15, 2025 14:20
Copy link
Collaborator

@dllehr-amd dllehr-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Lets get these changes merged!

@dllehr-amd dllehr-amd merged commit a6a60fb into 355_wip Nov 20, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants