Release 7.1.0 #149
Release 7.1.0 #149
Conversation
This commit fixes warnings when building with -Wall and -Wextra. In addition, removes old unused code related to prior pthread versions of ROSS as well as removing the ROSS_MEMORY related code, due to no longer being fully functional. * fixing warnings when building with Wall, etc * fixing warnings in buddy.c * fixing warnings in the rest of ROSS core * fixing warnings in instrumentation * fixing warnings with phold * fixing undefined reference causing linking error * adding warning flags to Travis builds * fixing some additional warnings that appear in release builds * minor changes to travis builds * removing old, unnecessary pthread related code * fixing ifdefs for ROSS_MEMORY * removing tw-memory related stuff for now * removing some unused stuff and unnecessary function arguments * lots of documentation for network-mpi and removing some unnecessary stuff * keeping the ROSS models submodule from being used in Travis tests * minor fix for C++ Travis build * adding installing phold to bin * adding some RPATH commands to CMakeLists.txt for Spack * removed ROSS-Models and template model submodule * update readme for submodule details * rpath in pkg-config * adding develop branch to Travis safelist
* updating the way the version number is grabbed, so we can have the actual version and not the git commit * fixing an error that caused coveralls to fail
* see if gcov and clang versions match * maybe we should be using lcov... since we apt-get it * whitespace * what version is llvm-cov? * use llvm-cov * llvm-cov gcov * remove cov version checks
|
This looks great to me. |
… as well as having ROSS output both version number and commit, instead of just version
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
===========================================
- Coverage 70.73% 58.42% -12.31%
===========================================
Files 35 32 -3
Lines 3977 3541 -436
===========================================
- Hits 2813 2069 -744
- Misses 1164 1472 +308
Continue to review full report at Codecov.
|
|
Brought in Elsa's recent PR that fixed coverage. Also decided to make some adjustments to the way I was doing the version number in ROSS. So now a simulation outputs version, commit and some other info. For example: The "12" after the version number is the number of commits since the version tag. So when running directly on master branch, this should be 0, because all commits to master should have a new version tag. The part after the g is the commit hash, and if the repo is dirty, it will append "-dirty" to the end. |
|
Love the versioning info!!!!!! |
In this release, we've cleaned up some old code from ROSS (related to old threaded ROSS, ROSS_MEMORY) as well as fixing warnings. Added -Wall and -Wextra flags for the build process in Travis.
Also since we've started using actual version numbers for ROSS, I updated the Cmake build to grab the actual version number from the commit tags, instead of just using the commit itself. So now a run will output the actual version number (making it easier if someone sends us ROSS output with an error to figure out what version they're actually using), as well as updating the package config output for the actual version number.
The README has been updated and README-vis removed. README-vis was way out of date (but the relevant webpages are up-to-date).
There's also been some fixes to the building of static or shared libraries. There is a ROSS_BUILD_SHARED_LIBS option now. If set to OFF (default), static libraries are built, otherwise shared libraries are built. This info has also been added to the installation instructions on the webpage.
@gonsie Any other minor changes we should add in before merging to master?
If this merge represents a feature addition to ROSS, the following items must be completed before the branch will be merged:
Include a link to your blog post in the Pull Request.