Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Huge gap between compiling ppu modules and spu modules (#13534) #13877

Closed
Megamouse opened this issue May 17, 2023 · 6 comments
Closed
Labels
LLVM Related to LLVM instruction decoders Regression

Comments

@Megamouse
Copy link
Contributor

For some time now we have a weird gap between compiling ppu modules and spu modules.
It's ~7 seconds for Fear. And nothing is logged in between.

image

@JuanjoSevilla3

This comment was marked as off-topic.

@solarmystic
Copy link

solarmystic commented May 18, 2023

This can be definitively traced back to #13534, it was never an issue on LLVM14.

0.0.27-14845 (last build before LLVM16) - instantaneous progression from the end of one phase to the other.

LLVM14.mp4

Current master (post LLVM16) - Note the really long gap (6s) between the end of linking PPU modules and building SPU cache

LLVM16.mp4

@Darkhost1999
Copy link
Contributor

At least it's not 65+ seconds like the less fortunate games. I really can't complain if it was only ~7

FPS_.30.03._.Vulkan._.0.0.27-15007._.Grand.Theft.Auto.V.BLUS31156.2023-05-17.20-45-53.mp4

@AniLeo AniLeo changed the title Huge gap between compiling ppu modules and spu modules Huge gap between compiling ppu modules and spu modules (#13534) Jun 24, 2023
@AniLeo AniLeo changed the title Huge gap between compiling ppu modules and spu modules (#13534) [Regression] Huge gap between compiling ppu modules and spu modules (#13534) Jun 24, 2023
@AniLeo
Copy link
Member

AniLeo commented Jun 27, 2023

Worth retesting with #14090

@solarmystic
Copy link

solarmystic commented Jun 27, 2023

#14090 doesn't fix this particular issue unfortunately, there's still an abnormally long pause between the end of Linking PPU modules and the start of building SPU cache.

ppu.mp4

12 seconds in the video above when booting up GT5 using the PR build.

@AniLeo
Copy link
Member

AniLeo commented Jan 1, 2024

Very likely fixed by #14848, please ask to reopen if it's not fixed on your side

@AniLeo AniLeo closed this as completed Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LLVM Related to LLVM instruction decoders Regression
Projects
None yet
Development

No branches or pull requests

5 participants