[Regression] TLoU and GT6 bugs after #14104

[Linear524]

Quick summary

TLoU and GT6 have bugs after #14104
TLoU shadowmaps are screwed (projected shadows from dynamic light sources).
GT6 have weird green pixelated garbage at lower right corner.
Screensots attached.

Details

Build with regression

#14104

Attach two log files

RPCS3.log

Attach capture files for visual issues

https://drive.google.com/file/d/1eKeW9HAsyOLNFaEnsmFNYMFd_mlLtG5N/view?usp=sharing

System configuration

SYS: RPCS3 v0.0.28-15306-d41fe80b Alpha | master
SYS: Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz | 14 Threads | 31.83 GiB RAM | TSC: 2.594GHz | AVX+ | FMA3 | TSX disabled by default
SYS: Operating system: Windows, Major: 10, Minor: 0, Build: 18362, Service Pack: none, Compatibility mode: 0
SYS: Current Time: 2023-07- 5T23:24:13
RSX: Found vulkan-compatible GPU: 'NVIDIA GeForce GTX 1080' running on driver 531.61.0.0
SYS: Firmware version: 4.87

Other details

I use WCB + RCB + WDB + RDB and native 720p mode.
For TLoU I use only RSX lighting patch and no other patches.

[AniLeo]

Probably fixed by 14140, try again

[solarmystic]

Unable to reproduce this in TLOU using the latest master (v0.0.28-15311) which has #14140 already merged, it is quite possible that this issue has already been resolved in that PR for TLOU.

[Linear524]

Sorry, but it still broken...
14140 have not fixed this...
@solarmystic
On your screen I see no dynamic shadows at all, that's why you don't see that issue...
Maybe you are using some MLAA skipping pathes or resolution scaling ?
Also I'm using all accuracy settings, like RCB+RDB+WCB+WDB to reproduce all effects...

[Megamouse]

Can you please upload a new log with logging enabled?
It seems you had set "Disable all logging" in your global config.

[Linear524]

Sure, here it is:
RPCS3.log

[Linear524]

Also:
here is the screenshots from version 15277, which have all projected shadows propertly rendered

Please look how Sarah casts her shadows and how dynamic light sources are working... They are broken in latest revisions.

[Linear524]

And here is RSX capture from v.15277 with working shadows and lighting:
https://drive.google.com/file/d/1_HRCP0ht3ZmSeHMOc9tUkads8uOWTNFV/view?usp=sharing

[kd-11]

@Linear524 Let's start with the easy one - explain how to reproduce the green blotch on GT6. I'm not able to reproduce that one.

[Linear524]

I'm just using my regular max-accuracy settings:
WCB+RCB+WDB+RDB, also I using Antialiasing on Auto, Shader Quality always on Ultra on every game, Zcull Accuracy on Precise, and Native 720p resolution without any tweaks...
All latest builds shows this green pixelated mess on lower right corner for GT6...

[kd-11]

Could be a pascal-specific problem. Which track did you test with?

[Linear524]

Every track, but mostly Nurburgring, second option

[kd-11]

Then it's probably pascal (maybe all nvidia?) rounding mode issue in shaders. I'll try and reproduce on the nvidia card later although it is a newer model.

[kd-11]

Verified the tlou bug, it's caused by projected coordinate scaling with the new setup. We need some more work around that special case.

[Clarke2131]

i've noticed something, on build 15277 tlou works fine but when i tested on 15302 and later builds the marks on the screen appears

issue https://youtu.be/jZq87fz0gLc
works fine https://youtu.be/hfzT6jznRrk

my specs are: ryzen 5 5600, 32GB, RX570 (23.5.2)

RPCS3 15277.log
RPCS3 15302.log

[kd-11]

TLOU shadow issue should be fixed by #14149

[kd-11]

@Clarke2131 There have been many fixes since 15302 specifically to fix those artifacts. The issue is only relevant if it still happens after 15311

[Clarke2131]

fair enough my bad 😅, here is the 15318

RPCS3.log

[readywer]

The same pr caused a regression on GT5 too. But it only happens during b-spec default view and in the race menu where you see the track form above.

[kd-11]

@Linear524 The PR got improvements and was merged. Please retest.

[Linear524]

Thanks KD-11 ! :)
TLoU shadows fixed )
Tonight I will retest GT6 and close this issue :)

[Linear524]

Hi KD-11 ! )
GT6 still have those green pixelated garbage on lower left part of screen, but if I disable WCB+RCB+WDB+RDB and enable Force CPU Blit instead = those green garbage is gone ! A lot of PostProcessing FX is gone too without WCB, but hey - it is still playable :>
So I'm sure it is related to overall broken WCB function and I'm also sure it will be gone once you finish #10208...
I'm closing this current issue.

P.S. - is it possible for you to complete #10208 this year ?)) I know it is not so simple, but a lot of titles will benefit from this fix :)