Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Virtual subimage views #14104

Merged
merged 25 commits into from
Jul 4, 2023
Merged

rsx: Virtual subimage views #14104

merged 25 commits into from
Jul 4, 2023

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jun 27, 2023 •
edited
Loading

This PR is part 2 of several restructuring PRs. This set reworks how we handle sampling a sub-region of a subresource by lowering the complex path of nested copies to a simple coordinate scale and clamp operation. This works very well for some usage cases, such as games that render static resources once then make subimages from the different sections for actual rendering. This PR can result in a massive speedup on smaller GPUs without super-fast GDDR6X memory but there are diminishing returns on the highest end stuff (e.g RTX 4090).
A modest speedup reported in GT series games, but there are other chokepoints that are addressed in followup PRs.

This PR is still WIP as I need more testing.
TODO:

  • Address the FIXMEs in texture cache
  • Add some debug overlay stats
  • Fix shader interpreter

Broken games:

  • TLOU
  • GT6

@kd-11 kd-11 marked this pull request as draft June 27, 2023 15:02
@Megamouse Megamouse added the RSX label Jun 27, 2023
Megamouse
Megamouse reviewed Jun 27, 2023
View reviewed changes
@kd-11 kd-11 force-pushed the virtual-subimage-views branch from 84f70d7 to db507f0 Compare June 30, 2023 22:46
@kd-11 kd-11 marked this pull request as ready for review July 1, 2023 00:36
@kd-11 kd-11 force-pushed the virtual-subimage-views branch from ad04ccf to 02a0072 Compare July 2, 2023 01:17
@kd-11 kd-11 changed the title [WIP] rsx: Virtual subimage views rsx: Virtual subimage views Jul 2, 2023
@Kravickas
Copy link
Contributor

Kravickas commented Jul 2, 2023 •
edited
Loading

GT6 1.22

F {RSX [0x0d4dc84]} SIG: Thread terminated due to fatal error: Unsupported image layout 0x5
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\RSX\VK\VKRenderPass.cpp:89[:25], in function set_layout)

RPCS3.log

@kd-11 kd-11 marked this pull request as draft July 2, 2023 15:54
kd-11 added 19 commits July 3, 2023 18:51
@kd-11
rsx: Add the glsl files
63235b3 
- Generated from inline strings in GLSLCommon.cpp
@kd-11
rsx: Switch common codegen to use the glsl scripts
4b2d99d
@kd-11
rsx: Migrate vertex fetch out of the cpp file
d789ec8
@kd-11
rsx: Fix fragment program codegen
3032664
@kd-11
rsx: Rework texture coordinate handling to support clamping and a mor…
c03be3d 
…e sane scale-bias setup
@kd-11
rsx: Fix shader compilation when texture ops are referenced
8ba6bf0
@kd-11
rsx: Minor optimization to speed up texture state sync a bit given th…
cc30127 
…e larger structure in use now
@kd-11
rsx: Implement GPU copy ellision through coordinate transform
7acec35 
- TODO: Some corner cases still exist where format may not be a match after a cache merge.
@kd-11
rsx: Implement atlas trivialization pass
a3858db 
- Decompose sequences of copies into the minimally required set.
  This does 2 things:
  a. Reduces GPU workload by doing less transfers
  b. Allows the clipping optimization to kick in and skip a ton of GPU work
@kd-11
vk: Do not clear memory if we're going to overwrite it with a copy an…
eaaee13 
…yway
@kd-11
rsx: Trivially detect single-image-blit transfer operations
6e61e68
@kd-11
rsx: Lower single-image-blit to a scaled coordinate fetch
e50ff86
@kd-11
rsx: Formatting and tidying changes
9f9bb41
@kd-11
vk: Fix namespace pollution in sync module
41bc9c7
@kd-11
rsx: Use designated initializer for the dangerous copy_region_descrip…
d8e2e48 
…tor type

- We need to move more dangerous braced initializations to c++20
- Also adds a base address variable which will come in handy
@kd-11
rsx: Properly fill in the cyclic ref field for framebuffer references
1ed1ff7
@kd-11
rsx: Force compatibility checks when applying fast-path optimizations
e668a7a
@kd-11
rsx: Insert missing texture barrier
f14beb4
@kd-11
rsx: Fix sampled descriptor address corruption
6d1e25d
@kd-11 kd-11 force-pushed the virtual-subimage-views branch from 02a0072 to 6d1e25d Compare July 3, 2023 18:03
@kd-11
Copy link
Contributor Author

kd-11 commented Jul 3, 2023

@Kravickas Please retest. The crash should be fixed.

@kd-11 kd-11 marked this pull request as ready for review July 3, 2023 18:29
@kd-11 kd-11 marked this pull request as draft July 3, 2023 18:31
@Kravickas
Copy link
Contributor

Yep, crash fixed. 👍

@kd-11 kd-11 marked this pull request as ready for review July 3, 2023 21:51
@kd-11 kd-11 merged commit 79e000f into RPCS3:master Jul 4, 2023
@kd-11 kd-11 deleted the virtual-subimage-views branch July 4, 2023 06:31
@solarmystic solarmystic mentioned this pull request Jul 5, 2023
Closed
@Linear524 Linear524 mentioned this pull request Jul 6, 2023
Closed
@readywer readywer mentioned this pull request Jul 10, 2023
Closed
@jeremybris jeremybris mentioned this pull request Sep 20, 2023
Closed
@Jonathan44062 Jonathan44062 mentioned this pull request Dec 4, 2023
Open
@kd-11 kd-11 mentioned this pull request Dec 24, 2023
Open
@Triticum0 Triticum0 mentioned this pull request Jan 4, 2024
Closed
@digant73 digant73 mentioned this pull request Jan 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse left review comments

Assignees
No one assigned
Labels
RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kd-11 @Kravickas @Megamouse