Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] SSX Green/Blue Smoke Graphical Bug On/After v0.0.21-13531 (#11867) #14659

Closed
jeremybris opened this issue Sep 20, 2023 · 4 comments
Labels
Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver Regression

Comments

@jeremybris
Copy link

jeremybris commented Sep 20, 2023

Quick summary

On/after v0.0.21-13531 (PR #11867) Smoke is green, should be white/grey, specifically, on the level "Explore" > "Alaska" > "Foraker" > "Invincible: Race it". Later, it regressed again, from green to blue smoke.

My save game, if needed to replicate:

Details

RPCS3 Version RPCS3 Commit RSX Capture Screenshot
Before v0.0.21-13531 ------------- Before RSX Capture Before
After v0.0.21-13531 PR #11867 After RSX Capture After

System configuration

Settings:

  • Default settings of the emulator, with "Vulkan".

Specs:

  • CPU - AMD 7900 (non-x)
  • GPU - AMD 6900x
  • Motherboard - Asus 670 Wifi

Other details

The smoke regressed again from green to blue. I can not find the build that regressed it because SSX stopped going in-game briefly. I found it's between build 15184 - 15312, probably one of kd-11's PRs:

RPCS3 Version RPCS3 Commit RSX Capture Screenshot
Before v0.0.28-15183 ------------- ------------- After
After v0.0.28-15312 (Maybe PR #14104 ?? Explanation below.) Blue Smoke RSX Capture Screenshot 2023-09-19 213517

In addition, a different smoke effect is now missing (probably related, went missing at the same time:

RPCS3 Version Screenshot
Before v0.0.28-15183 Screenshot 2023-09-19 214022
After v0.0.28-15312 Screenshot 2023-09-19 213123

Edit: Tried to find the second regression. Of kd-11's ~7 PR's during this time period, only this PR changes similar files to PR #11867 (green smoke). They both have changes to "rpcs3/Emu/RSX/Program/GLSLCommon.cpp", lines 23-500.

@ItsLaguna
Copy link

ItsLaguna commented Sep 20, 2023

Cannot reproduce on latest master on my savefile. The save you provided is the ghost data, not your profile, so I couldn't try that. I also don't know how you're playing a daytime stage at night 🤔

CPU: Ryzen 5800X
GPU: RTX 2060
Log: RPCS3.log

image
image2

@jeremybris
Copy link
Author

jeremybris commented Sep 20, 2023

Cannot reproduce on latest master on my savefile. The save you provided is the ghost data, not your profile, so I couldn't try that. I also don't know how you're playing a daytime stage at night 🤔

Ah, thanks for the comment. Maybe an AMD GPU bug (I have AMD 6900x). To play at night, you click on "Exploration" in the main menu. It's a level in Alaska. I re-uploaded the correct save data.

Edit: Tested on another computer (AMD 6900HS, 3060 Mobile). No problems on that computer.

@ItsLaguna
Copy link

To play at night, you click on "Exploration" in the main menu. It's a level in Alaska. I re-uploaded the correct save data.

Just started a new save and it's night time too, so my only guess is that maybe times changed because of the Online mode? Since my save is from back when I played in PS3 guess I'm stuck with these 😄

Also still can't reproduce even with your save, so maybe it's only on AMD GPUs like you said 😕

@AniLeo AniLeo changed the title [Regression] SSX Green/Blue Smoke Graphical Bug On/After v0.0.21-13531 [Regression] SSX Green/Blue Smoke Graphical Bug On/After v0.0.21-13531 (#11867) Jan 1, 2024
@AniLeo AniLeo added Regression Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver labels Jan 1, 2024
@jeremybris
Copy link
Author

jeremybris commented Oct 20, 2024

This appears to be fixed for me on my 6900 xt, on the latest RPCS3, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver Regression
Projects
None yet
Development

No branches or pull requests

3 participants