fix vfs::host::rename. #11584
Merged
fix vfs::host::rename. #11584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- resolve_path requires the path to be valid and can only be used before the call to fs::rename, not after.
|
Fixed, installs correct 8.34Gb of data again. |
|
I think it's a case in point of why we should move to std::filesystem::weakly_canonical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve_path requires the path to be valid and can only be used before
the call to fs::rename, not after.
issue popped up after 49c5ce3 since it replaced the internal fs:escape_path with the QT one.
fixes #10148.