[ppu] Fix arm64 trampoline #12242
Merged
[ppu] Fix arm64 trampoline #12242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always override the LLVM triple to prevent linking errors.
Disabling warnings for soundtouch allows Clang to compile in debug mode.
Nekotekina
reviewed
Jun 18, 2022
sguo35
force-pushed
the
arm64
branch
2 times, most recently
from
f2800ea to
47a972a
Compare
- Refactor function manager trampoline to be cleaner - Add trampoline impl for arm64 - Force all JIT entrypoints on Apple to toggle W^X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always override the LLVM triple on macOS arm64 to prevent linking errors. This line was removed in #12228
Fixes the function manager trampoline with a proper arm64 implementation, and clean up the code a bit.
Disables warnings on soundtouch dependency to allow Clang debug builds to work.
This gets LLVM PPU w/SPU interpreter on arm64 Mac to start a game with no segfaults, but it fails with
id 101 is not supported in the current check mode: content_permission::check_mode::disc_game. Currently working on figuring out if this is caused by arm64 or if it's macOS because it works just fine in Rosetta.Build instructions same as #12115