SPU: Extend Inaccurate SPU reservations

[elad335]

Unleashes performance in some game.
Implements #12030
Fixes #9476

[Yahfz]

closes #9476 too

[Jonathan44062]

Master

PR

No difference?

[Yahfz]

Master

PR

No difference?

did you use the setting?

[Jonathan44062]

What setting exactly? there's the log the PR build
RPCS3.log.gz

[YuriNator557]

SPU Accurate Reservations must be set to false, generate a new custom configuration and find it in the custom config file

[solarmystic]

Yep I see the improvement, from 66 to 71 FPS on average, with Accurate SPU Reservations set to false.

PR

Master

[Jonathan44062]

Yup, Slight improve performance with Accurate SPU Reservations to False in my CPU i7 8700

[Yahfz]

Yup, Slight improve performance with Accurate SPU Reservations to False in my CPU i7 8700

By looking at the screenshots on your issue, it seems like you had 34fps there. So it seems like there's another regression missing too?

[Jonathan44062]

No idea, it was the same performance for me, I can't really tell if it is an regression or not

Another place in performance, taking screenshot is kinda hard to get exact FPS, because is very random
Master - Accurate SPU Reservations: True
https://user-images.githubusercontent.com/78843189/189270847-bc5ad6e4-ee3d-4675-a2ed-29ca43d4e6df.mp4

PR - Accurate SPU Reservations: False
https://user-images.githubusercontent.com/78843189/189270927-8ae100c7-01f0-4330-9099-751c0d85106f.mp4

Slight improve performance

[Xcedf]

Master/PR Accurate SPU reservations: true

Custom build with non-accurate puttluc

PR Accurate SPU reservations: false

[elad335]

Packed more stuff in this setting.

[MsDarkLow]

i7-8700K @ 5GHz | Windows 11
Tested Yakuza Ishin Main menu, there is a big fps improvement in the PR when going from True to False

• Testing TSX vs No TSX delivers similar results and its all within margin of error.
• When comparing MLAA patch between Master and the PR its also all within margin of error (RSX bottleneck)

Yakuza Ishin Main Menu	Accurate SPU True		Accurate SPU False
	PR	Master	PR	Master
TSX Disabled	41.9	40.1	76.2	38.8
TSX	38.6	same as above	77.3	same as above
MLAA Patch	202.2	similar	206.0	similar

[Nerboruto]

• Testing TSX vs No TSX delivers similar results and its all within margin of error.

I tried to enable tsx on xeon e3-1230v3 on motorstorm pacific game and in fact from what I could now understand tsx does not give any advantage of fps ...
if I can solve the problems with capframex that crashes I will be able to have precise numbers.

[Augusto7743]

GOWA not start if using
SPU Accurate Reservations = false