Fix Visual Studio 17.5.0 compilation #13434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
added
the
Build and CI
Megamouse
force-pushed
the
fixVs
branch
2 times, most recently
from
6148a37 to
e1bedeb
Compare
For some reason there's an internal compiler error related to atomic wait. I could work around this issue when I commented "mask = default_mask<X>;". So after playing around a bit I had the suspicion that the VS parser can't handle some of the templatization. Giving the decltype its own alias seems to fix this issue (and makes the code a bit more readable anyway in my opinion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason there's an internal compiler error related to atomic wait.
I could work around this issue when I commented
mask = default_mask<X>;.So after playing around a bit I had the suspicion that the VS parser can't handle some of the templatization.
Giving the decltype its own alias seems to fix this issue (and makes the code a bit more readable anyway in my opinion).