cellAudio: Move and partially fix _mxr000 hack #14501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Aug 18, 2023
Megamouse
reviewed
Aug 18, 2023
Megamouse
reviewed
Aug 18, 2023
elad335
force-pushed
the
cell
branch
4 times, most recently
from
9f56195 to
73d2d3d
Compare
Megamouse
reviewed
Aug 18, 2023
|
Turns out what is actually slow is cellAudioPortOpen, takes 150us on PS3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cellAudioSetNotifyEventQueue waits for VSH threads to respond for port creation and connection to the event queue key provided. I believe this delay is what caused the need for the hack in sys_ppu_thread_start. I added the delay to cellAudioSetNotifyEventQueue for any key and added a long loop (but not infinite as before) waiting for _mxr000 to be created.
Edit: the delay is actually due to cellAudioPortOpen.