-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Improved 24-bit format handling and shader refactoring #15065
Conversation
Hey the hollowed out part of issue #10754 has been fixed by this: |
Also this almost fixes my new #15063 issue, but on Windows it now displays only one plant at a time like TOD does on every platform. |
- Some formats may have dummy channels on host. Never write to them! - This means that XRGB formats correctly only write 24 bits, not 32.
I think I know what this issue is. I'll revisit some time in the near future. |
This PR is making every game with Shader Quality on "Low" crash on startup with it stating: |
#ifdef _32_BIT_OUTPUT | ||
// Default. Used when we're not utilizing native fp16 | ||
#define round_to_8bit(v4) (floor(fma(v4, vec4(255.), vec4(0.5))) / vec4(255.)) | ||
// Everything is fp32 on ouput channels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Everything is fp32 on ouput channels | |
// Everything is fp32 on output channels | |
Hi - I’ve just finished Resistance 2 (another Insomniac game) on the steam deck and had the exact same issue with a lot of the grass there being bright green and luminescent (lots of it in the prologue level). By eye, it looks like it could be the same asset. I tried various settings that were suggested for other Insomniac games in case that may do something but didn’t have any luck. |
Changes