Add matching2 option handling #15601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RipleyTom
force-pushed
the
add_match2_option
branch
from
b9b4be6 to
2c02038
Compare
|
The titles Wolfenstein and Enemy Territory: Quake Wars had problems creating a room before (but in combination with custom servers) since they used a static buffer size mentioned above. This PR fixes that, tested with the both of them. |
RipleyTom
force-pushed
the
add_match2_option
branch
from
2c02038 to
39afd1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching2 contexts have an option setting that had gone unnoticed until now, it can specify if the game is interested in online name and avatar url data.
Until know we ignored that setting and gave the games both but some games fail on SceNpMatching2GetRoomMemberDataInternalLocal because they use a static buffer size for data which is insufficient for both online name and avatar url.