With MapTool default layout Draw Explorer is open but not checked in Window menu

[Phergus]

Describe the bug
With the default layout for MapTool the Draw Explorer is visible but not checked in the Window menu. Selecting the Draw Explorer in the Window menu makes it active and checked in the Window Menu but unchecks the Map Explorer.

To Reproduce
Steps to reproduce the behavior:

1. Open MapTool
2. Backup layout.dat file in config dir if you want to keep your layout.
3. Select Restore layout from Window menu.
4. Note Map and Draw Explorer windows are open but only Map Explorer is checked.

Expected behavior
Expect Window menu to reflect the currently open/closed windows.

Screenshots

MapTool Info

• Version: 1.5.8 (but has been this way for a long, long time.
• Install: Any

Desktop (please complete the following information):

• OS: Windows
• Version: 10

Additional context
The Select and Global macro windows also appear to toggle each other's status in the Menu.

[Merudo]

I don't see the problem? In the picture you have Map Explorer showing and the Draw Explorer not showing. The menu reflects that.

[Phergus]

I've always assumed the check mark indicated windows that were open, i.e. not closed. So I think both Map and Draw Explorer should be checked. Not sure what the point is of having the check indicate that window is the top of a set of tabbed panels. That's immediately obvious looking at the group where the tab names are visible as is the frame label indicating which one is on top.

If I have a window open, but not docked, it might be hiding behind another un-docked window. Both will be checked and because of that I know they are both open.

Not having looked at the code I'm guessing though that the current behavior is intentional so probably should just leave it alone.

[Azhrei]

It's likely that the JIDE implementation changed over the years. When Trevor first implemented it, it probably was "opened panels" vs. "visible panels".

[Phergus]

That could be. Changing it at this point may not be worth the effort unless they are others that are bothered by this.

[Azhrei]

Well, if someone wants to look for a new method call/API, then great, but yeah, I’m not going to lose any sleep over it. We can just leave it open as a reminder...

[melek]

Just to add a note, tabbed panels that aren't on top are never checked in the window menu, so the default layout is following the same rules as any custom layouts.

Here is a quick example with all the panels as tabs in one window: