Check windows based on hidden status, not showing #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
force-pushed
the
bugfix/1030-check-windows-when-docked
branch
from
bfd5ebf to
4c0435a
Compare
cwisniew
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #1030
Description of the Change
In the Window menu, windows now have a check whenever they are open. The old check is based on
isShowing(), an AWT property that checks whether the component happens to be visible on screen (e.g., not hidden behind anything else). The new check is based onisHidden(), a JIDE concept that checks whether a frame is hidden by the docking manager'shideFrame().This also means windows can be closed from the Window menu even if they aren't the active tab.
A similar use of
isShowing()for Tool > Chat seems to be intentional so I've left it in place.Possible Drawbacks
None.
Documentation Notes
N/A
Release Notes
This change is