Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Function/Menu Option for Token/Stamp Images #106

Closed
rkathey opened this issue Jun 25, 2016 · 10 comments
Closed

Reset Function/Menu Option for Token/Stamp Images #106

rkathey opened this issue Jun 25, 2016 · 10 comments
Assignees
Labels
feature Adding functionality that adds value low Low priority bug/enhancement macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@rkathey
Copy link
Contributor

rkathey commented Jun 25, 2016

An option added to the Token popup menu to restore default size and orientation to a MapTool token or stamp along with a MTScript function to do the same.

@rkathey rkathey added the feature Adding functionality that adds value label Jun 25, 2016
@rkathey rkathey added this to the 1.4.3.x Dev Build milestone Jun 25, 2016
@JamzTheMan JamzTheMan added the up for grabs Minimal context and are well-suited for new contributors label Sep 26, 2018
@JamzTheMan
Copy link
Member

We still looking to add this one? Another quick hit?

@source-knights
Copy link
Contributor

some questions about that (or maybe I'm missing something here):

  • Is facing == orientation?
  • I think a clear facing facing is already in the menu for token
  • is the default size for token just setting it back to medium?
  • I don't see any option to change size or facing of a draw stamp

@Phergus
Copy link
Contributor

Phergus commented Mar 15, 2019

I think this needs some further explanation. As you say, we already have Clear Facing on the menu and the size can be reset as well via the Size sub-menu.

@rkathey
Copy link
Contributor Author

rkathey commented Mar 15, 2019

When you're manipulating stamps you can royally foul it up by flipping, and drag resizing it. What I would like is a way to reset it to its original dropped state and start over. Note, an undo function would help as well but that part of MapTool really needs some refactoring and love (or so I"m told).

To see the issue, drop an image onto the background layer then click the small box in the corner and drag it around.

@Phergus
Copy link
Contributor

Phergus commented Mar 15, 2019

So perhaps a Native Size option just under Free Size? Should it also reset any rotation or leave that to the Clear Facing item?

@rkathey
Copy link
Contributor Author

rkathey commented Mar 15, 2019

Yes, that would work perfectly fine for the size reset to use native size.

I'm not sure if the reset flips is obvious with native size but I think it still works. They'd figure it out after one try. The case could be made the resetting flips isn't that big a deal since it's pretty easy to reverse that one.

I would leave reset rotation to clear facing. I don't know that's it's obvious that facing and rotation are the same thing for new users. It's not much of a learning curve.

All that said, the term reset (to me) is obvious for all of those things.

My main pain point is around sizing. The rest is gravy.

@Phergus
Copy link
Contributor

Phergus commented Mar 15, 2019

Both Reset Size and Native Size seem obvious as to what they would do to me. The question would be what is the behavior on the Token layer. Does it go to Medium or the Native Size. For the first option, Reset Size would be the only choice. For the second option, either would work.

@rkathey
Copy link
Contributor Author

rkathey commented Mar 15, 2019

I think on the token layer Native Size makes the most sense. Basically, you're setting it to free size and removing any free-size size modifications.

@Phergus
Copy link
Contributor

Phergus commented Mar 15, 2019

I'm 100% with that.

source-knights added a commit to source-knights/Maptool that referenced this issue Mar 15, 2019
@source-knights
Copy link
Contributor

source-knights commented Mar 15, 2019

Added a Reset Size popup menu entry. As far as I understand it resets the size as defined. Clear facing and flipping still left to the original menu entries.

Also introduced new resetSize function doing same as the menu entries for reset size.

Fix in #311

@cwisniew cwisniew removed this from the 1.4.3.x Dev Build milestone Mar 20, 2019
source-knights added a commit to source-knights/Maptool that referenced this issue Mar 23, 2019
JamzTheMan added a commit that referenced this issue Mar 31, 2019
@JamzTheMan JamzTheMan added low Low priority bug/enhancement macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) and removed up for grabs Minimal context and are well-suited for new contributors labels Mar 31, 2019
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value low Low priority bug/enhancement macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Development

No branches or pull requests

5 participants