Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "mapName" parameter and localization to MacroFunctions #1072

Closed
Merudo opened this issue Jan 4, 2020 · 3 comments
Closed

Add "mapName" parameter and localization to MacroFunctions #1072

Merudo opened this issue Jan 4, 2020 · 3 comments
Assignees
@Merudo
Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Jan 4, 2020

Is your feature request related to a problem? Please describe.
Meta macro functions such as getMacroProps and getMacroIndexes do not have a "mapName" argument.

Additionally, the error messages of the meta macro functions are not localized.

Describe the solution you'd like
Add a mapName macro argument to the functions, and add localization to the error messages.
Merudo added a commit to Merudo/maptool that referenced this issue Jan 5, 2020
@Merudo
Add mapName and localization to MacroFunctions
fc7bc7a 
- Add parameter "mapName" to MacroFunctions
- Add localization to MacroFunctions error message
- Fix applyToSelected ignored by createMacro
- Close RPTools#1072,  RPTools#1075
@Merudo Merudo mentioned this issue Jan 5, 2020
Merged
@Phergus Phergus added the feature Adding functionality that adds value label Jan 5, 2020
@Phergus Phergus added documentation needed Missing, out-of-date or bad documentation macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) labels Jan 5, 2020
@aliasmask
Copy link

I would really like to see this done for at least getMacroProps and getMacroIndexes just so the macro command text can be read from other maps. But having all the meta macro functions with map option would allow something like my RPEdit work from different maps.

@Merudo
Copy link
Member Author

Merudo commented Jan 15, 2020

PR #1076 added the mapname parameters to the MacroFunctions.

Documentation has been updated:

@Phergus Phergus added tested This issue has been QA tested by someone other than the developer. and removed documentation needed Missing, out-of-date or bad documentation labels Jan 15, 2020
@Phergus
Copy link
Contributor

Phergus commented Jan 16, 2020

Functions tested using ID/Map Name.

@Phergus Phergus closed this as completed Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Merudo @Phergus @aliasmask