Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lights using GRID may display incorrect sized radius #1243

Closed
JamzTheMan opened this issue Feb 4, 2020 · 1 comment
Closed

Lights using GRID may display incorrect sized radius #1243

JamzTheMan opened this issue Feb 4, 2020 · 1 comment
Assignees
@JamzTheMan
Labels
bug claimed Issue is being actively worked on. M Medium impact. T-shirt style story pointing/scope tested This issue has been QA tested by someone other than the developer.

Comments

@JamzTheMan
Copy link
Member

JamzTheMan commented Feb 4, 2020 •
edited by Phergus
Loading

Describe the bug
Lights of type GRID may display wrong size if using maps of different grid sizes.

To Reproduce
Steps to reproduce the behavior:

  1. Create a light with radius of 20 and of type GRID then apply to token on a map with grid size 50
  2. Create new map with grid size of 100 and place same light on a token
  3. Lighted area will be half the size needed

Expected behavior
Light should be the same radius regardless of grid size.

MapTool Info

  • Version: 1.5.x
  • Install: Any

Desktop (please complete the following information):

  • OS: Any
  • Version Any

Additional context
For performance, GRID radius is built using combined awt Areas and are cached the first time one is created for a given radius but is cached using the current grid size.
@JamzTheMan JamzTheMan added bug claimed Issue is being actively worked on. M Medium impact. T-shirt style story pointing/scope labels Feb 4, 2020
@JamzTheMan JamzTheMan self-assigned this Feb 4, 2020
@JamzTheMan JamzTheMan mentioned this issue Feb 4, 2020
Merged
Phergus added a commit that referenced this issue Feb 4, 2020
@Phergus
Merge pull request #1244 from JamzTheMan/develop
e3925a3 
Fix for GRID light issue #1243
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Feb 6, 2020
@Phergus
Copy link
Contributor

Phergus commented Feb 6, 2020

Tested. Lights created using the GRID shape occupy the same number of grid cells no matter the pixels per grid setting.

@Phergus Phergus closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamzTheMan JamzTheMan

Labels
bug claimed Issue is being actively worked on. M Medium impact. T-shirt style story pointing/scope tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamzTheMan @Phergus