Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Confirm Drawing Delete dialog #1271

Closed
Phergus opened this issue Feb 10, 2020 · 2 comments
Closed

Cleanup Confirm Drawing Delete dialog #1271

Phergus opened this issue Feb 10, 2020 · 2 comments
Assignees
Labels
bug code-maintenance Adding/editing javadocs, unit tests, formatting.

Comments

@Phergus
Copy link
Contributor

Phergus commented Feb 10, 2020

Describe the bug
Cleanup of code, adding comments & javadocs, use appropriate JOptionPane members, add notes to Crowdin concerning the I18N strings for same.

Note: The I18N strings used in the dialog have mnemonic keys defined but because of the custom text used for the buttons the JOptionPane dialog won't use them which is why the & is stripped out before use.

@Phergus Phergus added bug code-maintenance Adding/editing javadocs, unit tests, formatting. labels Feb 10, 2020
@Phergus Phergus self-assigned this Feb 10, 2020
@Phergus
Copy link
Contributor Author

Phergus commented Feb 10, 2020

Set appropriate dialog type and set default (Enter key) to be No.
Replaced magic numbers with proper JOptionPane values.
Replaced dump of stacktrace in getBackupManager() to showError() call because it was right there.
Updated/added javadocs.

@Phergus
Copy link
Contributor Author

Phergus commented Feb 15, 2020

No visible to changes for end users unless an error starting the backup manager should occur.

@Phergus Phergus closed this as completed Feb 15, 2020
Phergus added a commit that referenced this issue Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code-maintenance Adding/editing javadocs, unit tests, formatting.
Projects
None yet
Development

No branches or pull requests

1 participant