Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE on Hero Lab tokens if XML data is missing #1296

Closed
JamzTheMan opened this issue Feb 19, 2020 · 1 comment
Closed

NPE on Hero Lab tokens if XML data is missing #1296

JamzTheMan opened this issue Feb 19, 2020 · 1 comment
Assignees
@JamzTheMan
Labels
bug S Small impact. T-shirt style story pointing/scope tested This issue has been QA tested by someone other than the developer.

Comments

@JamzTheMan
Copy link
Member

Describe the bug
This shouldn't normally happen but user reported running Hero Lab using Wine on Linux and any portfolio created doe not save the XML data for an unknown reason.

To Reproduce
Steps to reproduce the behavior:

  1. Extract the Grognard.por from the attached hero-lab-test.zip
  2. Attempt to import Grognard
  3. See error

hero-lab-test.zip

Expected behavior
MapTool should handle NPE gracefully and note that the XML file is missing.

MapTool Info

  • Version: 1.5.+
  • Install: Any

Desktop (please complete the following information):

  • OS: Linux via Wine
  • Version Unknown
@JamzTheMan JamzTheMan self-assigned this Feb 19, 2020
@JamzTheMan JamzTheMan added bug S Small impact. T-shirt style story pointing/scope labels Feb 19, 2020
JamzTheMan added a commit to JamzTheMan/MapTool that referenced this issue Feb 19, 2020
@JamzTheMan
Bug fix for NPE when Hero Lab XML data missing
77f3b87 
 * Now gracefully handles NPE and inserts error message as the XML

Fixes RPTools#1296

Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
@JamzTheMan JamzTheMan mentioned this issue Feb 19, 2020
Merged
JamzTheMan added a commit to JamzTheMan/MapTool that referenced this issue Feb 19, 2020
@JamzTheMan
Bug fix for NPE when Hero Lab XML data missing
3d6e863 
 * Now gracefully handles NPE and inserts error message as the XML
 * Update to <error /> tag

Fixes RPTools#1296

Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Phergus added a commit that referenced this issue Feb 19, 2020
@Phergus
Update CHANGE_LOG.md
b051ba6 
Updated with #1296
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Feb 20, 2020
@Phergus
Copy link
Contributor

Phergus commented Feb 20, 2020

Tested. POR files missing the xml statblock load correctly now.

@Phergus Phergus closed this as completed Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamzTheMan JamzTheMan

Labels
bug S Small impact. T-shirt style story pointing/scope tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamzTheMan @Phergus