Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro export - nonsense message #1381

Closed
bubblobill opened this issue Mar 16, 2020 · 4 comments
Closed

Macro export - nonsense message #1381

bubblobill opened this issue Mar 16, 2020 · 4 comments
Assignees
@Merudo
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@bubblobill
Copy link
Collaborator

Describe the bug
Exporting macro in 1.5.10 where file exists.
Expected file exists/overwrite dialogue. Got nonsense message in dialog instead.
Still functions as overwrite confirmation, just the message is confusing.

To Reproduce
Export macro in 1.5.10 to file that already exists.

Expected behavior
Overwrite confirmation.

Screenshots
Untitled

MapTool Info

  • Version: 1.5.10
  • Install: New, Upgrade [previous version], or JAR [Java Version]
  • OS: Win 10
@Phergus Phergus added the bug label Mar 16, 2020
Merudo added a commit to Merudo/maptool that referenced this issue Mar 25, 2020
@Merudo
Fix nonsense message when overwrite on macro export
acac781 
- Fix RPTools#1381
@Merudo Merudo mentioned this issue Mar 25, 2020
Merged
@Merudo
Copy link
Member

Merudo commented Mar 25, 2020

PR #1415 fixes this.

@Phergus
Copy link
Contributor

Phergus commented Mar 26, 2020 •
edited
Loading

While the fix does correct the message content, it doesn't address the issue of overwriting an existing file without a warning. Strike that. Rechecked and am seeing the overwrite warning now.

@Phergus
Copy link
Contributor

Phergus commented Mar 26, 2020 •
edited
Loading

I see what happened. If the name field just has the name of the macro without the extension it will overwrite an existing saved macro without warning.

Merudo added a commit to Merudo/maptool that referenced this issue Mar 28, 2020
@Merudo
Fix macro export message to always give warning if overwriting a file
58dae9f 
- Issue discussed in RPTools#1381
@Merudo Merudo mentioned this issue Mar 28, 2020
Merged
@Phergus
Copy link
Contributor

Phergus commented Mar 30, 2020

Tested with update. Exporting a macro with specifying the file extension now warns on overwrite.

@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Mar 30, 2020
@Phergus Phergus closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Merudo @Phergus @bubblobill