Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAllPropertyNames ignores delim parameter if non-json #1400

Closed
Merudo opened this issue Mar 22, 2020 · 2 comments
Closed

getAllPropertyNames ignores delim parameter if non-json #1400

Merudo opened this issue Mar 22, 2020 · 2 comments
Assignees
@Merudo
Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Mar 22, 2020 •
edited by Phergus
Loading

Describe the bug
The function getAllPropertyNames ignores the delimiter parameter is it is something else than json, and instead use , as the delimiter.

To Reproduce
Steps to reproduce the behavior:

  1. type [getAllPropertyNames("Basic", "-")]
  2. observe how it returns the properties with , as the delimiter

MapTool Version
At least as far back as 1.4.0.5. Maybe always.
Merudo added a commit to Merudo/maptool that referenced this issue Mar 22, 2020
@Merudo
Fix getAllPropertyNames ignoring delim parameter
525d40b 
- Close RPTools#1400
@Merudo Merudo mentioned this issue Mar 22, 2020
Merged
@Merudo
Copy link
Member Author

Merudo commented Mar 22, 2020

PR #1401 fixes this.

@Phergus Phergus added bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) labels Mar 22, 2020
@Phergus Phergus added the documentation needed Missing, out-of-date or bad documentation label Mar 22, 2020
@Phergus Phergus added tested This issue has been QA tested by someone other than the developer. and removed documentation needed Missing, out-of-date or bad documentation labels Mar 23, 2020
@Phergus
Copy link
Contributor

Phergus commented Mar 23, 2020 •
edited
Loading

Tested. Wiki page updated.

@Phergus Phergus closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus