Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw Explorer drawings depend on pen width even if foreground is invisible #1408

Closed
Merudo opened this issue Mar 25, 2020 · 3 comments
Closed
Assignees
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Mar 25, 2020

Describe the bug
If a drawing is made with no foreground, the displayed picture on the map does not depend on the selected pen width.

However, the drawing in the draw explorer reflects the selected pen width, even if there is no reason for it to do so.

To Reproduce
Steps to reproduce the behavior:

  1. Select the Rectangle in Drawing Tools
  2. Select no foreground by clicking Cancel while selecting the foreground color
  3. Set the pen width to something really high, for example 60, and draw a rectangle
  4. Draw the same rectangle but with a pen width set to 1.
  5. Notice how different the two rectangles are in the Drawing Explorer.

Expected behavior
If no foreground texture/color is picked, the drawing does not depend on the pen width.

@Merudo
Copy link
Member Author

Merudo commented Mar 25, 2020

PR #1409 fixes this.

@Phergus
Copy link
Contributor

Phergus commented Mar 26, 2020

Select no foreground by clicking Cancel while selecting the foreground color

Just FYI, you can just left-click or right-click in the top-left palette square to get transparent for fore/background respectively.

@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Mar 26, 2020
@Phergus
Copy link
Contributor

Phergus commented Mar 26, 2020

Tested. Preview of drawing in Drawing Explorer matches the drawing on the map.

@Phergus Phergus closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Development

No branches or pull requests

2 participants