Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Enter in a HTML5 control loses the focus #1456

Closed
Merudo opened this issue Apr 3, 2020 · 2 comments
Closed

Pressing Enter in a HTML5 control loses the focus #1456

Merudo opened this issue Apr 3, 2020 · 2 comments
Assignees
@Merudo
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Apr 3, 2020

Describe the bug
Pressing Enter in a control (such as TextField) in a HTML5 frame / dialog sends the focus to the Chat Window.

To Reproduce
Steps to reproduce the behavior:

  1. Run the following script:
[frame5("test"):{
<textarea id="story" name="story" rows="5" cols="33">
It was a dark and stormy night...
</textarea>
}]
  1. Click on textbox.
  2. Press Enter. Notice the focus goes to the chat box.

Expected behavior
Focus stays on the frame.

MapTool Info

  • Version: 1.6.0 beta 2
  • Install: New

Desktop (please complete the following information):

  • OS: Windows
  • Version 10
Merudo added a commit to Merudo/maptool that referenced this issue Apr 3, 2020
@Merudo
Fix pressing Enter losing focus in HTML5 frame and dialog
ec26e76 
- Fix pressing the Enter key leading to focus going to the chat box.
- Close RPTools#1456
@Merudo Merudo mentioned this issue Apr 3, 2020
Merged
@Merudo
Copy link
Member Author

Merudo commented Apr 3, 2020

PR #1457 fixes this.

@Phergus Phergus added the bug label Apr 3, 2020
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Apr 3, 2020
@Phergus
Copy link
Contributor

Phergus commented Apr 3, 2020

Tested against supplied test case. Focus stays with Frame after hitting enter.

@Phergus Phergus closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus