transferVBL macro function is misnamed

[Phergus]

The transferVBL() function is somewhat misnamed. If you transfer something it is moved from one place to another. The function is really a copyVBL() function.

Changing this might break existing macros but it would be useful if it did what it said.

Alternatively a second parameter that determined transfer or copy could be added. This might also break existing macros as the current second parameter, token ID, would need to be pushed to the third slot.

[JamzTheMan]

Agreed. We could add add a copy of function and deprecate the current.

We could also use logic to deprecate functions :)

[Phergus]

Use logic? Inconceivable!

[JamzTheMan]

Marking some issues as "Help Wanted" that could be good places to start for new developers...

[source-knights]

Adding my opinion: I don't like copyVBL() either cause it would suggest I do a paste later. So I would more be a copyVBLTo…

What I suggest is adding an optional parameter to the transferVBL function.
transferVBL(value, id, delete)

Then if delete is true it actually deletes it, so equal to a real transfer/move.

That way we do not hit existing macro code and I guess its still doing what the idea of this Jira is.

If you guys agree and still want it I can add that.

By the way, the much bigger problem with VBL is the different scale between token and normal VBL (also just my POV ;) )

[Phergus]

Normal MT macro function usage is to have the token ID as the last, optional parameter.

So it would be:

transferVBL(to/from)
transferVBL(to/from, delete)
transferVBL(to/from, delete, id)

While that might break a handful of existing macros it shouldn't be a big impact as the function is probably not used much in framework code.

[source-knights]

I will change it in a way to not change current behaviour (by checking parameter types)

…

On Fri, 15 Mar 2019, 18:10 Phergus, ***@***.***> wrote: Normal MT macro function usage is to have the token ID as the last, optional parameter. So it would be: transferVBL(to/from) transferVBL(to/from, delete) transferVBL(to/from, delete, id) While that might break a handful of existing macros it should be a big impact as the function is probably not used much in framework code. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#189 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMBqs-PLBjDOsZe9jlKPmEWDNRKoe0reks5vW-IPgaJpZM4U-GDl> .

[source-knights]

Fix in #310
Amended to use a new Boolean optional delete parameter, fully backwards compatible.