Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error message when attempting to load map as campaign #225

Closed
Azhrei opened this issue Jan 19, 2019 · 3 comments
Closed

Change error message when attempting to load map as campaign #225

Azhrei opened this issue Jan 19, 2019 · 3 comments
Assignees
@Merudo
Labels
bug low Low priority bug/enhancement tested This issue has been QA tested by someone other than the developer.

Comments

@Azhrei
Copy link
Member

Azhrei commented Jan 19, 2019

The error message is the text from the exception (an inability to cast the PersistentMap type to the campaign type) and it would be better to just tell the user to import the map instead. Of course, if the Open Campaign dialog displayed .map files, that’s the first thing to correct...
@Phergus
Copy link
Contributor

Phergus commented Jan 19, 2019

By default the silly Open Campaign dialog views all file types and will attempt to open all file types. IT has a filter for .cmpgn files but it isn't set as the default.

@JamzTheMan JamzTheMan added bug low Low priority bug/enhancement 1 labels Feb 26, 2019
Merudo added a commit to Merudo/maptool that referenced this issue Aug 22, 2019
@Merudo
Fix Open Campaign dialog filter and error message
a69fdb8 
- Fix cmpgn filter not set as default in the Open Campaign dialog
- Change error message when opening a wrong maptool element as a campaign file
- Close RPTools#225
@Merudo Merudo mentioned this issue Aug 22, 2019
Merged
@Merudo
Copy link
Member

Merudo commented Aug 22, 2019 •
edited
Loading

PR #605 sets .cmpgn filter as default, and changes error message to:

File is not a MapTool campaign file. File is PersistedMap.

@Phergus
Copy link
Contributor

Phergus commented Aug 22, 2019

Tested. Campaign filter is default. Attempting to load other MT file types no longer throws exception.

@Phergus Phergus closed this as completed Aug 22, 2019
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug low Low priority bug/enhancement tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Azhrei @Merudo @JamzTheMan @Phergus