Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro Editor Auto-Completion #240

Closed
JamzTheMan opened this issue Feb 12, 2019 · 5 comments
Closed

Macro Editor Auto-Completion #240

JamzTheMan opened this issue Feb 12, 2019 · 5 comments
Assignees
@JamzTheMan
Labels
feature Adding functionality that adds value

Comments

@JamzTheMan
Copy link
Member

Turn on RSyntaxTextArea's auto-completion which adds word completion for Macro function names and display a short description + summary of the function.

Also add a few short hands for if/for/switch
@JamzTheMan JamzTheMan added the feature Adding functionality that adds value label Feb 12, 2019
@JamzTheMan JamzTheMan self-assigned this Feb 12, 2019
JamzTheMan added a commit to JamzTheMan/MapTool that referenced this issue Feb 12, 2019
@JamzTheMan
Added sample short hand completion for Issue RPTools#240
218f564 
Signed-off-by: Jamz <Jamz@Nerps.net>
@JamzTheMan JamzTheMan mentioned this issue Feb 12, 2019
Merged
JamzTheMan added a commit that referenced this issue Feb 14, 2019
@JamzTheMan
Extend MapToolScriptTokenMaker (#241)
d0f2ccf 
* Organized layout

Signed-off-by: Jamz <Jamz@Nerps.net>

* Macro Editor Changes

 * MapToolScriptSyntax now dynamically adds in all function names
retrieved by the MapToolLineParser
 * AutoCompletion turned on for Macro Editor! meta+space to activate
   * Macro short descriptions and summary text needs to be added.
Currently loading from a properties file.
 * Some refactoring...

Signed-off-by: Jamz <Jamz@Nerps.net>

* Added sample short hand completion for Issue #240

Signed-off-by: Jamz <Jamz@Nerps.net>

* Successful test of Spotless...

Signed-off-by: Jamz <Jamz@Nerps.net>

* Cleaned up i18n macro description, added line breaks

Signed-off-by: Jamz <Jamz@Nerps.net>
@JamzTheMan
Copy link
Member Author

The framework is done and ready to add descriptions. Will create another issue to track adding in descriptions.

@JamzTheMan JamzTheMan added 3 and removed 3 labels Feb 26, 2019
@Azhrei
Copy link
Member

Azhrei commented Mar 6, 2019 •
edited
Loading

Periods are treated as non-identifier characters so that json.sort doesn't autocomplete properly. @JamzTheMan already found the fix, so I'll submit a PR shortly.

Referenced solution: bobbylight/AutoComplete#48

@Azhrei Azhrei reopened this Mar 6, 2019
@JamzTheMan
Copy link
Member Author

Thanks!

@cwisniew
Copy link
Member

cwisniew commented Mar 9, 2019

Moving this to post Nerps fix as it isn't critical for the release hasn't been addressed for 4 days

@Azhrei
Copy link
Member

Azhrei commented Mar 9, 2019

This has been merged.

@Azhrei Azhrei closed this as completed Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamzTheMan JamzTheMan

Labels
feature Adding functionality that adds value
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cwisniew @Azhrei @JamzTheMan