Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info from getInfo() to Sentry logs #359

Closed
Azhrei opened this issue Mar 21, 2019 · 2 comments
Closed

Add info from getInfo() to Sentry logs #359

Azhrei opened this issue Mar 21, 2019 · 2 comments
Assignees
@xdy
Labels
feature Adding functionality that adds value

Comments

@Azhrei
Copy link
Member

Azhrei commented Mar 21, 2019

The info from getInfo("server") and getInfo("campaign") can be useful in error reports and should be added.

Currently, some of the information is there (like basic memory info) but the campaign info includes other configuration settings that can be useful for diagnosing stack traces.
@Phergus Phergus added feature Adding functionality that adds value up for grabs Minimal context and are well-suited for new contributors labels Aug 23, 2019
xdy added a commit to xdy-forks/maptool that referenced this issue Dec 9, 2019
@xdy
Working on RPTools#359, can't call getInfo("campaign") due to macro b…
6f0ff8c 
…eing untrusted. How to fix?
@xdy
Copy link
Collaborator

xdy commented Dec 9, 2019

Calling getInfo("server") works, but not sure how to call getInfo("campaign") from MapToolEventQueue.reportToSentryIO so as to avoid permission problems.
Any suggestions?

xdy added a commit to xdy-forks/maptool that referenced this issue Dec 28, 2019
@xdy
RPTools#359 If server is running, add info from getInfo("server") to …
7871b42 
…Sentry.

Switch to trusted context to  add info from getInfo("campaign") to Sentry, then switch back.
@xdy xdy mentioned this issue Dec 28, 2019
Merged
@Phergus Phergus removed the up for grabs Minimal context and are well-suited for new contributors label Dec 28, 2019
Phergus added a commit that referenced this issue Dec 28, 2019
@Phergus
Merge pull request #1034 from xdy-forks/issue359
b9cb704 
#359 If server is running, add info from getInfo("server") to Sentry.
@Phergus
Copy link
Contributor

Phergus commented Dec 31, 2019

Code merged. Will see if info shows up in the Sentry reports.

@Phergus Phergus closed this as completed Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xdy xdy

Labels
feature Adding functionality that adds value
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xdy @Azhrei @Phergus