Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines cannot be inserted except at the end in the Command panel #398

Closed
kayila opened this issue Mar 28, 2019 · 4 comments
Closed

Newlines cannot be inserted except at the end in the Command panel #398

kayila opened this issue Mar 28, 2019 · 4 comments
Assignees
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@kayila
Copy link
Contributor

kayila commented Mar 28, 2019

Describe the bug
Newlines in the command panel can only be inserted at the end. of the string.

To Reproduce
Steps to reproduce the behavior:

  1. Type something into the command panel
  2. Move the cursor somewhere in the middle of the line
  3. Press shift-enter

Expected behavior
A newline should be inserted wherever the cursor is.

MapTool Info

  • Version: 1.5.1
  • Install: Upgrade, JAR

Desktop (please complete the following information):

  • OS: Manjaro linux
  • Version: rolling
@Phergus
Copy link
Contributor

Phergus commented Mar 28, 2019

Don't see this issue under Win10. Shift-Enter or Enter both work at any point in the line. I assume you are referring to the Command editing field of the Macro Editor.

@Phergus
Copy link
Contributor

Phergus commented Mar 28, 2019

Ohh. You're talking about the Chat window.

@kayila
Copy link
Contributor Author

kayila commented Mar 28, 2019 via email

@Phergus
Copy link
Contributor

Phergus commented Mar 28, 2019

Figured that out when I looked at your patch. :) That's been like that forever. A little surprised that no one has asked for the fix before.

JamzTheMan added a commit that referenced this issue Mar 31, 2019
Fixes #398. Changed addition of newline character to be at cursor…
JamzTheMan added a commit that referenced this issue Mar 31, 2019
Revert "Fixes #398. Changed addition of newline character to be at cursor…"
JamzTheMan added a commit that referenced this issue Mar 31, 2019
Fixes #398. Changed addition of newline character to be at cursor…
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Apr 30, 2019
pnichols04 pushed a commit to pnichols04/maptool that referenced this issue Sep 5, 2019
pnichols04 pushed a commit to pnichols04/maptool that referenced this issue Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Development

No branches or pull requests

2 participants