Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying change on a macro from another map throws a null pointer exception #513

Closed
Merudo opened this issue Jul 29, 2019 · 1 comment
Closed

Applying change on a macro from another map throws a null pointer exception #513

Merudo opened this issue Jul 29, 2019 · 1 comment
Assignees
@Merudo
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Jul 29, 2019 •
edited
Loading

Describe the bug
Applying changes to a token macro from another map throw a null pointer exception. The error originates from save() in MacroButtonProperties, called by MacroButtonDialog. Full error message.

A similar error occurs if the token is deleted when the edit macro window is open.

To Reproduce

  1. Edit a macro on a token.
  2. Change map or delete token.
  3. Click "APPLY" or "OK" on the macro opened in 1.

Expected behavior
Changes are applied with no null pointer exception.

MapTool Info

  • Version: 1.5.3
  • Install: New,

Desktop (please complete the following information):

  • OS: Windows
  • Version: 10

Additional context
Regardless of the error, all changes appear to be saved.
@Phergus Phergus added the bug label Jul 29, 2019
@Phergus
Copy link
Contributor

Phergus commented Jul 29, 2019 •
edited
Loading

Missing an important point. This would only happen if you are editing a macro on a token.

Also, please include the relevant part of the exception.

Merudo added a commit to Merudo/maptool that referenced this issue Jul 29, 2019
@Merudo
Fixes RPTools#513 Null Pointer Exception on apply change to token macro
56c0d9e 
Fixed issue caused by two functions related to macro edit window that were looking for token only on current map.

However, token macro edit window remains open even if the token is no longer on the current map.

This fix make the two functions look for the token across all maps.
Merudo added a commit to Merudo/maptool that referenced this issue Jul 31, 2019
@Merudo
Fixes RPTools#513 Null Pointer Exception on apply change to token macro
f4bfb9d 
Fixed issue caused by two functions related to macro edit window that were looking for token only on current map.

However, token macro edit window remains open even if the token is no longer on the current map.

This fix make the two functions look for the token across all maps.
Merudo added a commit to Merudo/maptool that referenced this issue Aug 1, 2019
@Merudo
Fixes RPTools#513 Null Pointer Exception on apply change to token macro
ba93a6a 
Fixed issue caused by two functions related to macro edit window that were looking for token only on current map.

However, token macro edit window remains open even if the token is no longer on the current map.

This fix make the two functions look for the token across all maps.
Merudo added a commit to Merudo/maptool that referenced this issue Aug 1, 2019
@Merudo
Fixes RPTools#513 Null Pointer Exception on apply change to token macro
9373db0 
Fixed issue caused by two functions related to macro edit window that were looking for token only on current map.

However, token macro edit window remains open even if the token is no longer on the current map.

This fix make the two functions look for the token across all maps.
Merudo added a commit to Merudo/maptool that referenced this issue Aug 4, 2019
@Merudo
Fixes RPTools#513 Null Pointer Exception on apply change to token macro
c32972a 
Fixed issue caused by two functions related to macro edit window that were looking for token only on current map.

However, token macro edit window remains open even if the token is no longer on the current map.

This fix make the two functions look for the token across all maps.
Merudo added a commit to Merudo/maptool that referenced this issue Aug 5, 2019
@Merudo
Fixes RPTools#513 Null Pointer Exception on apply change to token macro
b5dadf4 
Fixed issue caused by two functions related to macro edit window that were looking for token only on current map.

However, token macro edit window remains open even if the token is no longer on the current map.

This fix make the two functions look for the token across all maps.
Merudo added a commit to Merudo/maptool that referenced this issue Aug 5, 2019
@Merudo
Fixes RPTools#513 Null Pointer Exception on apply change to token macro
5803fde 
Fixed issue caused by two functions related to macro edit window that were looking for token only on current map.

However, token macro edit window remains open even if the token is no longer on the current map.

This fix make the two functions look for the token across all maps.
@Merudo Merudo mentioned this issue Aug 5, 2019
Merged
Phergus added a commit that referenced this issue Aug 6, 2019
@Phergus
Merge pull request #518 from Merudo/MerudoApplyOK
9191a13 
Fix #513 Null Pointer Exception on apply change to token macro when token is on a different map
@Merudo Merudo closed this as completed Aug 8, 2019
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus