Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions in TokenImage.java to have mapName as optional parameter #541

Closed
Merudo opened this issue Aug 5, 2019 · 4 comments
Closed

Functions in TokenImage.java to have mapName as optional parameter #541

Merudo opened this issue Aug 5, 2019 · 4 comments
Assignees
@Merudo
Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Aug 5, 2019

Is your feature request related to a problem? Please describe.

It is a pain to change properties of tokens on other maps. Instead of having to change the map and possibly create flickering, it would be better to add the mapName as additional optional argument.

Describe the solution you'd like
I would like the following functions in TokenImage.java to take a mapName parameter so they could work on tokens in other maps:

getTokenImage
getTokenPortrait
getTokenHandout
setTokenImage
setTokenPortrait
setTokenHandout
setTokenOpacity
getTokenOpacity
Merudo added a commit to Merudo/maptool that referenced this issue Aug 5, 2019
@Merudo
Add mapName argument to functions in TokenImage.java, Close RPTools#541
fb97469 
Add mapName as optional argument (defaults to current map) in the following functions in TokenImage:

        getTokenImage
        getTokenPortrait
        getTokenHandout
        setTokenImage
        setTokenPortrait
        setTokenHandout
        setTokenOpacity
        getTokenOpacity

Add optional parameter tokenId to these functions:

        getTokenImage
        getTokenPortrait
        getTokenHandout

Add method "getZoneRenderer()" for type Token, which returns the zoneRenderer the token is on. Useful to update a token on another map.

Add method "getZoneRenderer(zoneName)" for  MapToolFrame. Works like getZoneRenderer(zone) and getZoneRenderer(zoneGUID), but takes the name of the map instead.
Merudo added a commit to Merudo/maptool that referenced this issue Aug 5, 2019
@Merudo
Add mapName argument to functions in TokenImage.java, Close RPTools#541
fb9e231 
Add mapName as optional argument (defaults to current map) in the following functions in TokenImage:

        getTokenImage
        getTokenPortrait
        getTokenHandout
        setTokenImage
        setTokenPortrait
        setTokenHandout
        setTokenOpacity
        getTokenOpacity

Add optional parameter tokenId to these functions:

        getTokenImage
        getTokenPortrait
        getTokenHandout

Add method "getZoneRenderer()" for type Token, which returns the zoneRenderer the token is on. Useful to update a token on another map.

Add method "getZoneRenderer(zoneName)" for  MapToolFrame. Works like getZoneRenderer(zone) and getZoneRenderer(zoneGUID), but takes the name of the map instead.
@Phergus Phergus added the feature Adding functionality that adds value label Aug 5, 2019
@Phergus Phergus added the in progress Issue is actively being worked on label Aug 5, 2019
@Merudo Merudo mentioned this issue Aug 5, 2019
Merged
Merudo added a commit to Merudo/maptool that referenced this issue Aug 5, 2019
@Merudo
Add mapName argument to functions in TokenImage.java, Close RPTools#541
156862a 
Add mapName as optional argument (defaults to current map) in the following functions in TokenImage:

        getTokenImage
        getTokenPortrait
        getTokenHandout
        setTokenImage
        setTokenPortrait
        setTokenHandout
        setTokenOpacity
        getTokenOpacity

Add optional parameter tokenId to these functions:

        getTokenImage
        getTokenPortrait
        getTokenHandout

Add method "getZoneRenderer()" for type Token, which returns the zoneRenderer the token is on. Useful to update a token on another map.

Add method "getZoneRenderer(zoneName)" for  MapToolFrame. Works like getZoneRenderer(zone) and getZoneRenderer(zoneGUID), but takes the name of the map instead.
Merudo added a commit to Merudo/maptool that referenced this issue Aug 6, 2019
@Merudo
Add mapName argument to functions in TokenImage.java, Close RPTools#541
bfb52b5 
Add mapName as optional argument (defaults to current map) in the following functions in TokenImage:

        getTokenImage
        getTokenPortrait
        getTokenHandout
        setTokenImage
        setTokenPortrait
        setTokenHandout
        setTokenOpacity
        getTokenOpacity

Add optional parameter tokenId to these functions:

        getTokenImage
        getTokenPortrait
        getTokenHandout

Close RPTools#541
Merudo added a commit to Merudo/maptool that referenced this issue Aug 6, 2019
@Merudo
Add mapName argument to functions in TokenImage.java, Close RPTools#541
9afaa8c 
Add mapName as optional argument (defaults to current map) in the following functions in TokenImage:

        getTokenImage
        getTokenPortrait
        getTokenHandout
        setTokenImage
        setTokenPortrait
        setTokenHandout
        setTokenOpacity
        getTokenOpacity

Add optional parameter tokenId to these functions:

        getTokenImage
        getTokenPortrait
        getTokenHandout

Close RPTools#541
Merudo added a commit to Merudo/maptool that referenced this issue Aug 6, 2019
@Merudo
Add optional mapName argument to functions in TokenImage.java
cc95d54 
Add mapName as optional argument (defaults to the current map) in the following functions in TokenImage:

        getTokenImage
        getTokenPortrait
        getTokenHandout
        setTokenImage
        setTokenPortrait
        setTokenHandout
        setTokenOpacity
        getTokenOpacity

Add optional parameter tokenId to these functions:

        getTokenImage
        getTokenPortrait
        getTokenHandout

Close RPTools#541
Phergus added a commit that referenced this issue Aug 9, 2019
@Phergus
Merge pull request #542 from Merudo/TokenImage
bdc90ee 
Add mapName and/or tokenID arguments to functions in TokenImage.java (see above).  Removed redundant Zone.putToken() calls.  Moved duplicated code to new functions to handle parameters. Completes #541
@Phergus
Copy link
Contributor

Phergus commented Aug 9, 2019

Note that Wiki still needs to be updated for all of these changes.

@Phergus Phergus added the documentation needed Missing, out-of-date or bad documentation label Aug 9, 2019
@Phergus Phergus removed the in progress Issue is actively being worked on label Aug 13, 2019
@Phergus
Copy link
Contributor

Phergus commented Aug 13, 2019

Code changes complete.

@Phergus Phergus added the macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) label Aug 13, 2019
@Merudo
Copy link
Member Author

Merudo commented Aug 15, 2019 •
edited
Loading

Documentation updated:

https://lmwcs.com/rptools/wiki/getTokenImage
https://lmwcs.com/rptools/wiki/getTokenPortrait
https://lmwcs.com/rptools/wiki/getTokenHandout
https://lmwcs.com/rptools/wiki/setTokenImage
https://lmwcs.com/rptools/wiki/setTokenPortrait
https://lmwcs.com/rptools/wiki/setTokenHandout
https://lmwcs.com/rptools/wiki/setTokenOpacity
https://lmwcs.com/rptools/wiki/getTokenOpacity

@Merudo Merudo closed this as completed Aug 15, 2019
@Phergus
Copy link
Contributor

Phergus commented Aug 15, 2019

All functions tested and working as expected.

@Phergus Phergus added tested This issue has been QA tested by someone other than the developer. and removed documentation needed Missing, out-of-date or bad documentation labels Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus