Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions setName() and getName() to have mapName as optional parameter #547

Closed
Merudo opened this issue Aug 6, 2019 · 3 comments
Closed

Functions setName() and getName() to have mapName as optional parameter #547

Merudo opened this issue Aug 6, 2019 · 3 comments
Assignees
@Merudo
Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Aug 6, 2019

Is your feature request related to a problem? Please describe.
It is a pain to change properties of tokens on other maps. Instead of having to change the map and possibly create flickering, it would be better to add the mapName as additional optional argument.

Describe the solution you'd like
I would like the following functions in TokenImage.java to take a mapName parameter so they could work on tokens in other maps:

getName()
setName()
Merudo added a commit to Merudo/maptool that referenced this issue Aug 6, 2019
@Merudo
Add optional parameter mapName to getName() and setName()
85280c0 
Close RPTools#547
@Merudo Merudo mentioned this issue Aug 6, 2019
Merged
Merudo added a commit to Merudo/maptool that referenced this issue Aug 10, 2019
@Merudo
Add optional parameter mapName to getName() and setName()
27f23a8 
Close RPTools#547
Merudo added a commit to Merudo/maptool that referenced this issue Aug 11, 2019
@Merudo
Add optional parameter mapName to getName() and setName()
2ac8037 
Close RPTools#547
@Phergus Phergus added documentation needed Missing, out-of-date or bad documentation feature Adding functionality that adds value labels Aug 12, 2019
@Phergus Phergus added the macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) label Aug 12, 2019
@Phergus
Copy link
Contributor

Phergus commented Aug 13, 2019

Code changes complete. Added to giant stack of needed documentation.

@Merudo
Copy link
Member Author

Merudo commented Aug 15, 2019

Documentation updated:

https://lmwcs.com/rptools/wiki/getName
https://lmwcs.com/rptools/wiki/setName

@Merudo Merudo closed this as completed Aug 15, 2019
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Aug 15, 2019
@Phergus
Copy link
Contributor

Phergus commented Aug 15, 2019

Tested. Changes working as described.

@Phergus Phergus removed the documentation needed Missing, out-of-date or bad documentation label Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus