Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "mapName" to TokenStateFunction #563

Closed
Merudo opened this issue Aug 13, 2019 · 5 comments
Closed

Add "mapName" to TokenStateFunction #563

Merudo opened this issue Aug 13, 2019 · 5 comments
Assignees
@Merudo
Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Aug 13, 2019

Is your feature request related to a problem? Please describe.
It would be nice to add a "mapName" argument for functions "getState", "setState", "setAllStates".

Additional context
I would be glad to update the wiki but I do not have the permission to do so.
Merudo added a commit to Merudo/maptool that referenced this issue Aug 13, 2019
@Merudo
Add mapName param to TokenStateFunction, Fix setState bug
dffa042 
- Add optional parameter mapName to "getState", "setState", "setAllStates"
- Close RPTools#563
- Fix bug with setState (missing break; in Token.java)
- Change "setAllStates" to only refresh the frame once
- Cleanup of the functions
@Merudo Merudo mentioned this issue Aug 13, 2019
Merged
@Phergus Phergus added the feature Adding functionality that adds value label Aug 13, 2019
@Phergus Phergus added documentation needed Missing, out-of-date or bad documentation macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) labels Aug 13, 2019
@Phergus
Copy link
Contributor

Phergus commented Aug 13, 2019

Code changes complete. Documentation needed.

@Phergus
Copy link
Contributor

Phergus commented Aug 14, 2019

@Merudo Send me an email address via direct message on Discord and I'll set up an account for you on wiki.

@Merudo
Copy link
Member Author

Merudo commented Aug 14, 2019

Documentation updated:

http://www.lmwcs.com/rptools/wiki/getState
http://www.lmwcs.com/rptools/wiki/setState
http://www.lmwcs.com/rptools/wiki/setAllStates

@Phergus Phergus removed the documentation needed Missing, out-of-date or bad documentation label Aug 14, 2019
@Phergus
Copy link
Contributor

Phergus commented Aug 14, 2019

Issue complete.

@Phergus Phergus closed this as completed Aug 14, 2019
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Aug 20, 2019
@Phergus
Copy link
Contributor

Phergus commented Aug 20, 2019

Functions tested across maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus