Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost token if map change during token move #595

Closed
Merudo opened this issue Aug 20, 2019 · 5 comments
Closed

Ghost token if map change during token move #595

Merudo opened this issue Aug 20, 2019 · 5 comments
Assignees
@Merudo
Labels
bug medium Medium priority bug/enhancement tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Aug 20, 2019 •
edited
Loading

Describe the bug
During a token move, if the user changes map and click on another token, the original token becomes a "ghost" and cannot be moved anymore, and its path is permanently drawn on the map.

To Reproduce
Steps to reproduce the behavior:

  1. Start to move a token with the arrow keys, but don't complete the move.
  2. Change to another map.
  3. Select any token on that map.
  4. Return to the original map.
  5. The token cannot be moved anymore.

Expected behavior
The token can still be moved again.

Screenshots
The dragon token cannot be moved anymore, and the path can't be removed:

img

MapTool Info

  • Version: 1.5.3
  • Install: New

Desktop (please complete the following information):

  • OS: Windows
  • Version 10
@Phergus Phergus added the bug label Aug 20, 2019
@Phergus Phergus added the medium Medium priority bug/enhancement label Aug 20, 2019
@Phergus
Copy link
Contributor

Phergus commented Aug 20, 2019

Workaround: Drag another token onto the starting point of frozen token so as to get the overlapping tokens indicator in the top-right. Double-click on the overlap indicator and then select the frozen token to move it.

@Phergus Phergus added the up for grabs Minimal context and are well-suited for new contributors label Aug 20, 2019
@Azhrei
Copy link
Member

Azhrei commented Aug 20, 2019

Wow, good catch. It amazes me sometimes how people find these kinds of bugs, just the number of permutations that need to be tried...

@Merudo
Copy link
Member Author

Merudo commented Aug 20, 2019 •
edited
Loading

A lot of the bugs I find are discovered by stumbling into them while testing out new code.

This one I found while taking the screenshots for #594 :P

Merudo added a commit to Merudo/maptool that referenced this issue Nov 22, 2019
@Merudo
Fix ghost token if map changes during token drag
e77e3e9 
- Fix the token becoming unresponsive and its path imprinted on the map if a map change occurs while the token is being dragged
- Close RPTools#595
@Merudo Merudo mentioned this issue Nov 22, 2019
Merged
@Merudo
Copy link
Member Author

Merudo commented Nov 22, 2019

PR #926 fixes this issue.

@Phergus Phergus removed the up for grabs Minimal context and are well-suited for new contributors label Nov 22, 2019
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Nov 29, 2019
@Phergus
Copy link
Contributor

Phergus commented Nov 29, 2019

Tested. Working correctly now.

@Phergus Phergus closed this as completed Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug medium Medium priority bug/enhancement tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Azhrei @Merudo @Phergus