Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill selection box option does not work on layers other than Token #796

Closed
mrkwnzl opened this issue Oct 15, 2019 · 2 comments
Closed

Fill selection box option does not work on layers other than Token #796

mrkwnzl opened this issue Oct 15, 2019 · 2 comments
Assignees
@mrkwnzl
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@mrkwnzl
Copy link
Contributor

mrkwnzl commented Oct 15, 2019 •
edited
Loading

Describe the bug
When deselecting “Fill selection box” under “Preferences > Application > Performance”, this works only on the Token layer, but not on the layers Hidden, Object, and Background.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Preferences > Application > Performance'
  2. Deselect 'Fill selection box'
  3. Draw a selection box on any layer other than Token (Hidden, Object, or Background). The selection box is still filled.

Expected behavior
The selection box should not be filled on any layer, if “Fill selection box" is deselected, just as it is on the Token layer.

MapTool Info

  • Version: 1.5.6
  • Install: Upgrade from 1.5.4

Desktop (please complete the following information):

  • OS: MacOS
  • Version 10.15
@mrkwnzl mrkwnzl changed the title Fill selection box does not work on layers other than Token Fill selection box option does not work on layers other than Token Oct 15, 2019
@Phergus Phergus added the bug label Oct 15, 2019
xdy added a commit to xdy-forks/maptool that referenced this issue Dec 8, 2019
@xdy
RPTools#796 Always check getFillSelectionBox when painting selectionbox
926328a
@xdy xdy mentioned this issue Dec 8, 2019
Merged
@xdy
Copy link
Collaborator

xdy commented Dec 8, 2019

I just made a PR that should fix this, #976

@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Dec 13, 2019
@Phergus
Copy link
Contributor

Phergus commented Dec 13, 2019

Tested. Preference setting affects selection on all layers now.

@Phergus Phergus closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrkwnzl mrkwnzl

Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xdy @Phergus @mrkwnzl