Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing token VBL with setTokenVBL doesn't update client vision #932

Closed
Merudo opened this issue Nov 24, 2019 · 1 comment
Closed

Removing token VBL with setTokenVBL doesn't update client vision #932

Merudo opened this issue Nov 24, 2019 · 1 comment
Assignees
@Merudo
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Nov 24, 2019

Describe the bug
If a token has a VBL and it gets removed with setTokenVBL(), the clients do not get updated (soft fog not changed).

To Reproduce
Steps to reproduce the behavior:

  1. Create a token with VBL in a server with clients.
  2. Remove the VBL with setTokenVBL().
  3. Check the clients. They still see the VBL.

Expected behavior
Clients are properly updated.

MapTool Info

  • Version: 1.5.7
  • Install: New

Desktop (please complete the following information):

  • OS: Windows
  • Version: 10
Merudo added a commit to Merudo/maptool that referenced this issue Nov 24, 2019
@Merudo
Fix setTokenVBL() not updating clients
b6e043c 
- Fix so that setTokenVBL updates all clients.
- Add javadocs comments to vision and light methods
- Remove redundent updateTokenTree calls (already triggered by TOKEN_CHANGED event)
- Remove redundant tokenTopologyChanged: (already triggered by TOKEN_CHANGED if the token has VBL)
- Close RPTools#932
@Merudo Merudo mentioned this issue Nov 24, 2019
Merged
@Phergus Phergus added the bug label Nov 24, 2019
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Nov 29, 2019
@Phergus
Copy link
Contributor

Phergus commented Nov 29, 2019

Tested. Working as expected now.

@Phergus Phergus closed this as completed Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus