Fix for NPE when no theme prefs had been set and a few themes for variety #1226
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Same tools used as VBL with extra button that defines which layer(s) the polygons are drawn on. Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
* Same tools used as VBL with extra button that defines which layer(s) the polygons are drawn on. * Changes included (and to be tested) include client/server commands to properly send VBL/MBL to other clients * AppPreferences persist last ToolbarPanel presses * TODO: Make AI buttons for GM persist over to Player clients and disable buttons on Player clients when server is running Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
…ture-token-vbl-simplification
Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Feature MBL Branch
…plification Feature token vbl simplification
Fixes NPE when no them had previously been selected. Added a few themes for variety.
…thub.com/RPTools/maptool into develop" This reverts commit ab266dd, reversing changes made to fd65dea.
JamzTheMan
approved these changes
Feb 2, 2020
There was a problem hiding this comment.
Reviewed 9 of 12 files at r6.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Azhrei and @cwisniew)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no theme had previously been chosen an NPE was thrown on startup. Fixed #1225
Added a few themes just to provide something to choose from. #921
This change is