Decouples AssetPanel from Resource window so that each one can browse independently #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests done: - saving on a writable directory (succeeds) - saving on a writable directory where the file already exists (fails, asks for a new filename or directory) - saving on a non writable directory (fails, asks for a new directory) Refers to RPTools#1231
… independently Tests done: - new map/map => success - new map/background => success - drawing/choose paint => success Fixes RPTools#256
|
Nice, that's been an annoyance for a while now! |
Phergus
approved these changes
Feb 8, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests done:
Fixes #256
This change is