Removes uses of the deprecated IOUtils.closeQuietly #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wherever possible, use of IOUtils.closeQuietly has been replaced with try-with-resources - deprecates copyWithClose (no more needed) - removes some duplication in the save method of PackedFile A few invocations have been left out, mostly because there seem to be assumptions on when the close will actually happen, and we don't have a lot of tests around these methods.
- removes the last use of copyWithClose - also, replaces yet another try/finally with try-with-resources Refers to RPTools#1215
- removes the last use of copyWithClose - also, replaces yet another try/finally with try-with-resources Refers to RPTools#1215
Phergus
approved these changes
Feb 15, 2020
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few invocations have been left out, mostly because there seem to be assumptions on when the close
will actually happen, and we don't have a lot of tests around these methods.
Refers to #1215
This change is