Feature token vbl simplification #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getFileAsInputStream was using a try with resources, so it was always returning a closed InputStream. Also, added a couple of unit tests as a starting point for properly testing this class. Refers to RPTools#1215
Fixes the missing thumbnails for token problem
New Crowdin translations
Points to the latest version of maptool-resources with the additional maps
New Crowdin translations
The refactoring is actually about splitting the SysInfo class so that the code for handling the GUI is in one class and the code for dealing with gathering information is in another class. Also, it creates an interface (SysInfoProvider) so that the GUI depends from that. The function getInfoFunction, which was also depending on SysInfo, now only depends on MapToolSysInfoProvider, the concrete implementation of SysInfoProvider. This allows to test the "debug" function there (added a couple of unit tests to ensure everything still works). Refers to #126
Refers to #126 and RPTools#1313
Refactors SysInfo, to gather debug info asynchronously RPTools#1313
…tps://github.com/RPTools/maptool into develop"" This reverts commit f7500b4 Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
* No long requires 'valid geometry' which allows for vbl with 'holes' #needsTesting Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
…/JamzTheMan/MapTool into feature-token-vbl-simplification
Phergus
approved these changes
Feb 23, 2020
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
* No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. #needsTesting Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
* No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. #needsTesting Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
* Performance increase upwards of 50x * doubleclick on preview window resets preview scaling * No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. #needsTesting Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No long requires 'valid geometry' which allows for vbl with 'holes'
Should fix latest issue relayed in #1218
Hopefully has no other side affects, but the different methods do return varying point counts, not sure which method is "best" now. It depends on the original shape more now I think.
Tested previous tokens and new, VBL still seems to work ok...
This change is