Fix #324 getViewArea was returning an wrong formatted string. #325
Conversation
|
Fix for #324 |
|
We're cleaning up our Repo to follow GitFlow. I've targeted this against our Develop branch now. |
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @oliver-szymanski)
|
I'm not sure the numbers add up. I ran this script |
|
The numbers that are output agree with each other (for a grid size of 50 at 100% zoom) but the width and height in cells are way off for the view shown. Too funny. It is dividing the viewport size in pixels by grid size to get the size in cells and ignoring zoom level. |
|
It was broken this way in Nerps 1.4.5.4 as well. |
|
I only changed the formatting of the output, as this was reported as an
error, not the way it counts.
If you tell me what needs to be changed to fix the numbers I can add that
as well
…On Sat, 23 Mar 2019 at 12:42, Phergus ***@***.***> wrote:
It was broken this way in Nerps 1.4.5.4 as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#325 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMBqs1837e0iGKLzG6xEWAf-BNteHCSrks5vZiEYgaJpZM4b4Z2f>
.
|
|
Yeah. It's not something you did. It's been like this from the beginning. The question is what is the correct output in cell sizes for a view like above where partial cells are shown on all sides? Do you include the partials in the count or only those cells fully visible? Or do you divide the size in pixels by grid size and factor in zoom? Wouldn't think folks would want this but maybe. |
This change is