Enables add/update buttons on state type change #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #1711
Description of the Change
The
changeUpdatedmethod which was responsible for enabling/disabling the Add and Update buttons based on the state of the dialog was not called when the a new value was selected in the Type combo box; as a result, the state of the buttons was changed only when an event like changing the name of the state was triggered.Also, I renamed a couple of variables to make the logic of enabling/disabling a little clearer.
Possible Drawbacks
None that I can think of.
Documentation Notes
N/A
Release Notes
Enables/disables the add/update buttons when changing the State type in the State dialog.
This change is