Strips HTML tags from code completion list #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelsing
reviewed
Mar 23, 2023
| private static final ConcurrentMap<String, String> htmlCache = new ConcurrentHashMap<>(); | ||
|
|
||
| String remove(String htmlString) { | ||
| if (htmlString == null) return null; |
There was a problem hiding this comment.
Our coding style wants {} for one line ifs too. (even if spotless doesn't check it)
thelsing
approved these changes
Mar 28, 2023
cwisniew
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #391
Description of the Change
The summary is stripped of HTML tags using a very coarse regular expression which should match a
<...>sequence inside a short description. I intentionally left the regular expression simple, as we don't need a real HTML parser here, just something to strip the HTML tags away. We can complicate the expression as needed.The stripped strings are kept into an hashmap, which is then indexed by the unstripped string. We can't use a static approach, because additional macros or UDFs could be added, and require their own short description stripped.
Possible Drawbacks
The performance loss can be evaluated in terms of one hashmap look-up for each function each time we create the dialog, plus one string replacement for the first time we need to populate the cache. As the number of strings should be small (in the order of 1000) the loss should be small enough to be negligible.
Documentation Notes
N/A
Release Notes
This change is