Add token note types #3879
Merged
Add token note types #3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
approved these changes
Mar 22, 2023
|
I forgot to add the new token properties to the protobuf DTO. Will du so later. |
|
I need to look into some layouting issues that happen when the text is very long. |
|
Couldn't reproduce the issue. The ok button of the EditTokenDialog was pushed outsite the viewable area because the Textarea grew without adding a scrollbar. But it didn't happen again. |
|
@thelsing Spotless has reared its ugly head once again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
resolves #3791
Description of the Change
This change add a textType to notes and gmNotes of tokesn. The type can be changed in the token editor.
Currently text/plain, text/html and text/markdown are supported.
Markdown notes also get rendered on the hoverpanel now.
The generated Java code and the form xml was out of sync for two files. I also includes those changes to resync them.
Token without an explicit note type default to text/plain.
Possible Drawbacks
Nothing if I didn't mess something up.
Release Notes
Can be folded in the other PR of this FR.
This change is