Ensure a frame's undocked bounds are not null prior to using them #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwisniew
approved these changes
Mar 28, 2023
kwvanderlinde
deleted the
bugfix/3316-getInfo-client-NPE-undocked-bounds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #3316
Description of the Change
Prior to adding the undocked x, y, width and height to the result of
getInfo("client"), we now check that the bounds are not null. If it is null, we do not include these fields in the result.Possible Drawbacks
There may be frameworks counting on these fields always being present. This isn't a breaking change since this case has always resulted in a NPE anyways. Still, some updates may be needed.
Documentation Notes
N/A
Release Notes
getInfo("client")as a result of certain docked frames not having an undocked state.This change is