Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables Token Selection buttons when the server has no Individual Views #3885

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

emmebi
Copy link
Collaborator

@emmebi emmebi commented Mar 28, 2023

Fixes #656

Description of the Change

This PR disables the 4 Token Selection buttons when a client connects to a server without the Individual View policy.

The change is implemented via an additional method in the ToolbarPanel which can enable and disable the four buttons as a whole.

The method is called when a client connects to a server, if that is needed, and when the client either disconnects as a choice of the user or the server closes the connection.

Tests done

  • test with Individual Views: connect to a server with Individual Views enabled, and verify that the 4 buttons remain enabled
  • test without Individual Views: connect to a server with Individual Views disabled, and verify that the 4 buttons are disabled
    • verify that if the client disconnects, the buttons are re-enabled
    • verify that if the server disconnects, the buttons are enabled

Possible Drawbacks

None.

Documentation Notes

Buttons before connecting:

buttons_before_connecting

Buttons after connecting:

buttons_after_connecting

Release Notes

  • disables Token Selection buttons when the server has no Individual Views

This change is Reviewable

@cwisniew cwisniew merged commit 4144494 into RPTools:develop Mar 29, 2023
@cwisniew cwisniew added the bug label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 4 FoW buttons (right of A* toggle) don't do anything for players
2 participants