Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Diamond VBL Tooltip #4029

Merged
merged 7 commits into from
May 8, 2023
Merged

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented May 5, 2023

Identify the Bug or Feature request

fixes #4027

Description of the Change

Corrects the tooltip for diamond and hollow diamond VBL.

Possible Drawbacks

Should be none

Documentation Notes

Fix tooltip for Hollow Diamond and Diamond VBL.

Release Notes

  • Fix tooltip for Hollow Diamond and Diamond VBL.

This change is Reviewable

@cwisniew cwisniew added the bug label May 5, 2023
@cwisniew cwisniew requested a review from kwvanderlinde May 5, 2023 14:33
@cwisniew cwisniew changed the title Bump log4j Correct Diamond VBL Tooltop May 5, 2023
@cwisniew cwisniew changed the title Correct Diamond VBL Tooltop Correct Diamond VBL Tooltip May 5, 2023
@cwisniew cwisniew enabled auto-merge May 5, 2023 14:39
@cwisniew
Copy link
Member Author

cwisniew commented May 6, 2023

Updated to take into account @kwvanderlinde comments on them being used for isometric maps. Decided against disabling them for non isometric maps as they could still be useful on other map types.

@cwisniew cwisniew added this pull request to the merge queue May 8, 2023
Merged via the queue into RPTools:develop with commit f0c70b5 May 8, 2023
@cwisniew cwisniew deleted the fix-vbl-tooltips branch May 11, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: Diamond and Hollow Diamond VBL tools have incorrect tool tip
2 participants